keras-team / keras-io

Keras documentation, hosted live at keras.io
Apache License 2.0
2.75k stars 2.03k forks source link

fix: broken json file issue for tabtransformer jupyter notebook #1834

Closed Neo9061 closed 5 months ago

Neo9061 commented 5 months ago

There is a broken link on colab hyperlink at https://keras.io/examples/structured_data/tabtransformer/

google-cla[bot] commented 5 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Neo9061 commented 5 months ago

Can someone looked into the fix quickly or fix it for me?

sachinprasadhs commented 5 months ago

Thanks for your contribution, please make the changes in .md file as well and could you please remove this extra line in the .py file https://github.com/keras-team/keras-io/blob/39a09fce011919bcb51e8a6b29d7f6442c9ab068/examples/structured_data/tabtransformer.py#L569

Neo9061 commented 5 months ago

Thanks for your contribution, please make the changes in .md file as well and could you please remove this extra line in the .py file

https://github.com/keras-team/keras-io/blob/39a09fce011919bcb51e8a6b29d7f6442c9ab068/examples/structured_data/tabtransformer.py#L569

Done. @sachinprasadhs could you please accelerate the PR merge? this is a broken feature. And i am not sure if I have authority to contribute to this repository as I saw one of checking is failed with missing CLA.

sachinprasadhs commented 5 months ago

Could you please sign the CLA as well

Neo9061 commented 5 months ago

Hey i am from another company and I am not sure policy allows me to merge the PR. Any chance you can do it for me? This is broken feature in Google. I just want it to be fixed @sachinprasadhs

sachinprasadhs commented 5 months ago

Created PR and linked it above, closing this one. Thank you.