search

keras-team / keras

Deep Learning for humans
http://keras.io/
Apache License 2.0
61.06k stars 19.35k forks source link

Fix bug in layernorm with rms_scaling=True #19643

Closed SuryanarayanaY closed 2 weeks ago

SuryanarayanaY commented 2 weeks ago

Fix bug in LayerNormalization with rms_scaling set to True.

Fixes #19642

codecov-commenter commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.41%. Comparing base (f01e99a) to head (a1066dc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #19643 +/- ## ======================================= Coverage 78.41% 78.41% ======================================= Files 498 498 Lines 45500 45500 Branches 8388 8388 ======================================= Hits 35677 35677 Misses 8086 8086 Partials 1737 1737 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `78.25% <100.00%> (ø)` | | | [keras-jax](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `62.03% <100.00%> (ø)` | | | [keras-numpy](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `56.36% <100.00%> (ø)` | | | [keras-tensorflow](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `63.39% <100.00%> (ø)` | | | [keras-torch](https://app.codecov.io/gh/keras-team/keras/pull/19643/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `62.05% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.