search

keras-team / keras

Deep Learning for humans
http://keras.io/
Apache License 2.0
61.06k stars 19.35k forks source link

Add axis parameter to dice loss #19673

Closed td-jakubl closed 3 days ago

td-jakubl commented 1 week ago

https://github.com/keras-team/keras/issues/19637

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gbaned commented 1 week ago

Hi @td-jakubl Can you please sign CLA. Thank you!

td-jakubl commented 1 week ago

Hi @td-jakubl Can you please sign CLA. Thank you!

Done :)

td-jakubl commented 1 week ago

Hi @gbaned some test fails and perhaps this is not related to changes in this PR. Do you have any idea why?

codecov-commenter commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.69%. Comparing base (669a97a) to head (2501601). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #19673 +/- ## =========================================== - Coverage 81.47% 66.69% -14.79% =========================================== Files 498 498 Lines 45773 45757 -16 Branches 8458 8454 -4 =========================================== - Hits 37294 30517 -6777 - Misses 6577 13595 +7018 + Partials 1902 1645 -257 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `66.61% <100.00%> (-14.71%)` | :arrow_down: | | [keras-jax](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras-numpy](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `56.29% <100.00%> (-0.16%)` | :arrow_down: | | [keras-tensorflow](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras-torch](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `61.99% <100.00%> (-2.95%)` | :arrow_down: | | [keras.applications](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras.applications-jax](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras.applications-numpy](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras.applications-tensorflow](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | | [keras.applications-torch](https://app.codecov.io/gh/keras-team/keras/pull/19673/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

td-jakubl commented 3 days ago

LGTM, thank you for the contribution!

No, problem. I reformated code. Could you rerun workflows?