search

keras-team / keras

Deep Learning for humans
http://keras.io/
Apache License 2.0
62.13k stars 19.49k forks source link

Fix for https://github.com/keras-team/keras/issues/20425 #20453

Closed hertschuh closed 2 weeks ago

hertschuh commented 2 weeks ago

The issue was caused by the fact that the iterator was not fully consumed and on_epoch_end was not called.

Added an exception to catch this situation in the future.

Added a unit test to test model.fit() with all the combinations of data adapters.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (272bb90) to head (812bd8f). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...s/src/trainers/data_adapters/py_dataset_adapter.py 57.14% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20453 +/- ## ======================================= Coverage 82.01% 82.01% ======================================= Files 514 515 +1 Lines 47239 47275 +36 Branches 7413 7422 +9 ======================================= + Hits 38741 38772 +31 - Misses 6704 6706 +2 - Partials 1794 1797 +3 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `81.86% <62.50%> (+<0.01%)` | :arrow_up: | | [keras-jax](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `64.91% <62.50%> (+<0.01%)` | :arrow_up: | | [keras-numpy](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `59.84% <50.00%> (-0.03%)` | :arrow_down: | | [keras-tensorflow](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `65.91% <62.50%> (+<0.01%)` | :arrow_up: | | [keras-torch](https://app.codecov.io/gh/keras-team/keras/pull/20453/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `64.83% <62.50%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.