keras-team / keras

Deep Learning for humans
http://keras.io/
Apache License 2.0
62.13k stars 19.49k forks source link

implement transform_bounding_boxes for random_zoom #20526

Closed shashaka closed 3 days ago

shashaka commented 5 days ago

I have implemented the transform_bounding_boxes method to support random zoom functionality. If this implementation is satisfactory, I can proceed with adding corresponding test cases.

here is gist

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (c802ca6) to head (009ef4c). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...s/preprocessing/image_preprocessing/random_zoom.py 89.58% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20526 +/- ## ========================================== + Coverage 82.10% 82.14% +0.04% ========================================== Files 515 515 Lines 47790 47854 +64 Branches 7486 7493 +7 ========================================== + Hits 39238 39312 +74 + Misses 6738 6730 -8 + Partials 1814 1812 -2 ``` | [Flag](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | Coverage Δ | | |---|---|---| | [keras](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `81.99% <87.50%> (+0.04%)` | :arrow_up: | | [keras-jax](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `65.10% <83.33%> (+0.05%)` | :arrow_up: | | [keras-numpy](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `60.08% <83.33%> (+0.05%)` | :arrow_up: | | [keras-tensorflow](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `66.08% <83.33%> (+0.04%)` | :arrow_up: | | [keras-torch](https://app.codecov.io/gh/keras-team/keras/pull/20526/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team) | `65.02% <83.33%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=keras-team#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

shashaka commented 4 days ago

I've added test cases. If there are any corrections needed, please feel free to share them with me.