search

keras-team / tf-keras

The TensorFlow-specific implementation of the Keras API, which was the default Keras from 2019 to 2023.
Apache License 2.0
63 stars 28 forks source link

Add EfficientNet lite option [from tensorflow closed PR] #502

Closed davinnovation closed 1 year ago

davinnovation commented 2 years ago

System information.

TensorFlow version (you are using): 2.9.1 Are you willing to contribute it (Yes/No) : No

Describe the feature and the current behavior/state.

Add EfficientNet Lite option which is PRed in [Added Lite option to EfficientNets. #48400] https://github.com/tensorflow/tensorflow/pull/48400/ already

Will this change the current api? How? Yes. tf.keras.applications.efficientnet.EfficientNetB0(lite=True)

Who will benefit from this feature?

Contributing

tilakrayal commented 2 years ago

@davinnovation, Could you please elaborate about your Feature. Also, please specify the Use Cases for this feature. Thank you!

davinnovation commented 2 years ago

Hi! Thanks for your response. For clearance, efficientnet lite PR is not my credit - it was PRed by @sebastian-sz to the TensorFlow repo in 2021 Q3. This feature is adding "lite:bool" parameter to tf.keras.applications.efficientnet.EfficientNet and it makes loadable TF2-TFlite ready efficientnet-lite keras model.

EfficientNet lite is in TF-Hub, but it is for TF1 so it can't be easily ported with TF2-TFLite

If this feature is added, lots of users can easily port efficient-lite with the latest TF2-TFLite

sebastian-sz commented 2 years ago

@davinnovation Hi, sorry for not reopening the PR in Keras repository as promised.

If it will be accepted I am planning to add these models to keras-cv - I think this is the target place to add new vision keras.applications.

gadagashwini commented 2 years ago

Hi @sebastian-sz, It would be great if you raise PR in this repo. Thank you!

sebastian-sz commented 2 years ago

@gadagashwini in "this" repo, do you mean keras-cv or keras?

google-ml-butler[bot] commented 2 years ago

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Thank you.

google-ml-butler[bot] commented 2 years ago

Closing as stale. Please reopen if you'd like to work on this further.

gadagashwini commented 2 years ago

Hi @sebastian-sz, Apologies for delayed response. Please raise PR on Keras repo. Thank you!

sebastian-sz commented 2 years ago

@gadagashwini thanks, I will try to have a PR ready by the end of the week.

tilakrayal commented 1 year ago

@davinnovation, Could you please take a look at the related PR's where one PR was closed and the other one was merged. Also please take a look at this doc link and let us know if it serves the purpose. Thank you!

davinnovation commented 1 year ago

@tilakrayal Thanks for the noti. Merged PR is good enough :)

tilakrayal commented 1 year ago

@davinnovation, Could you please confirm if the issue is resolved. if yes, please feel free to move this issue to closed status. Thank you!