search

kerasking / maven-android-plugin

Automatically exported from code.google.com/p/maven-android-plugin
0 stars 0 forks source link

Proguard generate too long shell command because of .so libraries #319

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Especially on windows (I don't know if Linux has similr limitation) when  
android-maven-plugin run proguard it generate too long command and it fail.

I use maven jar dependency which many .so libraries dependencies. And main 
problem is that android-maven plugin add all of them to the proguard call, it 
look like

 -injars C:\Users\Tomas\.m2\repository\com\visualon\libvoTsParser\3.4.3\libvoTsParser-3.4.3.so(!META-INF/maven/**,!META-INF/MANIFEST.MF)

for every .so

I think that is useless do this with .so. Proguard don't need it, or yes? I 
think that only .jar should be added here.

Original issue reported on code.google.com by tomas.pr...@gmail.com on 8 Nov 2012 at 8:17

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
And btw. SO dependencies are added also to the DEX GOAL command line.
I don't know if DEX tool need it.

Original comment by tomas.pr...@gmail.com on 8 Nov 2012 at 8:20

GoogleCodeExporter commented 9 years ago 
Probably correct that so files should be excluded. Can you send a pull request?

Original comment by mosa...@gmail.com on 7 Dec 2012 at 6:23

GoogleCodeExporter commented 9 years ago 
I'm working on pull request now. I thinking about it.
It is necessary something different that jar artifacts type?
Because in ProguardMojo in collectProgramInputFiles() plugin create list off 
all dependencies and exclude only explicitly excluded by user (by 
isBlacklistedArtifact()) it contain .so .apklib, .jar, everythink. A then 
collectInputFiles() it iterate over whole list and exclude only .apklib. I 
think that much better would be simply modify (collectProgramInputFiles) to 
create list only from .jar files or I miss something?

Original comment by tomas.pr...@gmail.com on 25 Mar 2013 at 8:03

GoogleCodeExporter commented 9 years ago 
Really will be be much better migrate to github issues from here :-(

Original comment by tomas.pr...@gmail.com on 26 Mar 2013 at 8:30

GoogleCodeExporter commented 9 years ago 
I made pull request with fix already
https://github.com/jayway/maven-android-plugin/pull/191

Original comment by tomas.pr...@gmail.com on 4 Apr 2013 at 7:22

GoogleCodeExporter commented 9 years ago 
We are no longer using the issue tracking system on Google Code. Please refile 
this issue on https://github.com/jayway/maven-android-plugin/issues if you 
still have this problem with the latest release of the Android Maven Plugin

Original comment by mosa...@gmail.com on 19 May 2014 at 4:19