kerasking / maven-android-plugin

Automatically exported from code.google.com/p/maven-android-plugin
0 stars 0 forks source link

AAR generated with dependent AAR contains the classes from the AAR dependencies wgen it shouldn't #438

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create an AAR with AAR dep
2. Look at the classes in the created AAR.
3. They should not include the classes from the dep aar.

What version of maven-android-plugin are you using?
3.8.2

What are the complete output lines of "mvn -version" on your machine?
pache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-18 
01:22:22+1000)
aven home: D:\Dev\apache-maven-3.1.1
ava version: 1.7.0_45, vendor: Oracle Corporation
ava home: D:\Dev\jdk1.7.0_45\jre
efault locale: en_AU, platform encoding: Cp1252
S name: "windows 8", version: "6.2", arch: "amd64", family: "windows"

See discussion 
https://groups.google.com/forum/#!topic/maven-android-developers/4ezuuF2MSdo
See attached file

Original issue reported on code.google.com by william....@xandar.com.au on 6 Jan 2014 at 7:34

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
I just tested this too :) 

This is because the aar generation calls the "ConsumeAarMojo" which adds the 
classes of the aar dep in the target\classes folder which in turns gets picked 
up by the aar creation.

We have 2 possible solutions:

1. Change the ConsumeAarMojo
2. filter the aar classes out.

Original comment by benoit.b...@gmail.com on 6 Jan 2014 at 9:45

GoogleCodeExporter commented 9 years ago
Also, trying to set the dependent aar to scope=provided causes build failures 
due to missing classes. 

Original comment by Philip.S...@gmail.com on 12 Jan 2014 at 10:58

GoogleCodeExporter commented 9 years ago
Um, why would you setting an AAR dep to provided?

Original comment by william....@xandar.com.au on 12 Jan 2014 at 11:00

GoogleCodeExporter commented 9 years ago
I was trying to prevent the classes from being included in the generated aar. I 
was both trying optional / provided to mark the dependency as optional.

Original comment by Philip.S...@gmail.com on 12 Jan 2014 at 11:03

GoogleCodeExporter commented 9 years ago
fixed in 3.8.3-SNAPSHOT

Original comment by benoit.b...@gmail.com on 11 Feb 2014 at 5:47

GoogleCodeExporter commented 9 years ago
How do we close of these issues?

Original comment by william....@xandar.com.au on 11 Feb 2014 at 9:47

GoogleCodeExporter commented 9 years ago
Fixed in 3.9.0

Original comment by william....@xandar.com.au on 27 Feb 2014 at 10:28