keratin / authn-js

JavaScript client library for Keratin AuthN
GNU Lesser General Public License v3.0
45 stars 20 forks source link

consolidate UMD builds #8

Closed cainlevy closed 7 years ago

cainlevy commented 7 years ago

After #6, the persistence stores are fairly small and it's hard to justify the quasi-"tree shaking" that choosing between UMD bundles offers.

This change increases the file size for keratin-authn.min.js by 1.2kb (4.8kb -> 6.1kb). But it seems likely that any Vanilla JS environment will be a traditional stack that relies on cookies for server-side rendering so the net change from keratin-authn.cookie.min.js to the consolidated keratin-authn.min.js is only 0.4kb (5.7kb -> 6.1kb).

Vanilla JS stacks are still supported, but that level of micro-optimization is not worth the setup and onboarding process.

breaking change

Consolidating the bundles means a change in configuration syntax!

before: setSessionName after: setCookieStore or setLocalStorageStore