search

kerberos-io / agent

An open and scalable video surveillance system for anyone making this world a better and more peaceful place.
https://kerberos.io
MIT License
645 stars 79 forks source link

Save num of changes to filename, update a lot of dependencies and fix compiling develop branch #39

Closed olokos closed 1 year ago

olokos commented 1 year ago

This is an updated version of #37 and #38

This is the first implementation of the recording data being sent as a metadata struct, so it could be applied to the output filename of the recording.

I have also updated a lot of go and javascript (yarn/npm) dependencies.

I made Dockerfile to use node16 - since it's the latest LTS supported version aswell as some other improvements.

Each commits has quite well described commit message

With this commit I'm also updating develop branch to the current code state in master, so there will be no issues later on when merging this.

There are no changes in the code I've made since #37 I just resolved the conflicts caused by adding another commit to the original develop branch and recreated the PR

olokos commented 1 year ago

The build on GH Actions was still failing because of a tiny semantic difference in 3debf6297591ac4d638e498e0a08093e2e45844e What's interesting is that it was not failing the build at all on a local filesystem with yarn build at all, but on actions it somehow fail building. It wasn't really much of an issue, more of Eslint wanting the code to be perfect, preventing the build, but I fixed that in 87f84e993a249aea5bb14b6bee2e599083293866

After I fixed all of those issues, the logging works great, so really nice work @thomasqp ! Thank You!

olokos commented 1 year ago

image

This 1kb recording save bug seems to be the last actual issue with this entire PR!

I expect the bug to be somewhere here: https://github.com/kerberos-io/agent/pull/39/files#diff-ffdbf8bce9c0be9c74ac3d8965a566a7d26ec648b89d2a64cdce0122e96b03d0R279

I think this could be done better, but I'm not sure how.

Also @cedricve I highly suggest removing Codacy Static Code Analysis as 99% of the time it just fails without a good reason behind it, just like now.

olokos commented 1 year ago

Also, since this is on develop branch, I think this PR can be already merged to develop already.

https://hub.docker.com/r/olokos/agent-olokos/tags lastest build above or version 0.0.4.4 is 1:1 with this entire PR merged, including all of the improvements, if anybody wants to test

olokos commented 1 year ago

Bravo @olokos

Thank You! Feel free to merge! @cedricve :)

cedricve commented 1 year ago

merged thank you @olokos