search

kerberos-io / kerberos-docker

Run Kerberos Open Source inside a docker container.
http://doc.kerberos.io/opensource/installation#docker
103 stars 31 forks source link

IP/Port Config of Machinery #5

Open wcomartin opened 6 years ago

wcomartin commented 6 years ago

It would be nice if the Web Docker had a config variable for the Machinery IP and Port Instead of using the hostname machinery and a static port 8889 this make using multiple docker container pairs very difficult, I had to bash into the container to override the hosts file and the port in the nginx config.

cedricve commented 6 years ago

hey @wcomartin, thanks for your advice. My docker knowledge is limited, do you see any solution to resolve this matter?

wcomartin commented 6 years ago

Hey sorry I haven't responded earlier, I will see if i can put together a PR to fix, do you accept PRs?

cedricve commented 6 years ago

ofcourse @wcomartin , awesome!

wcomartin commented 6 years ago

I was just thinking about this a bit more, and I think that adding the variables to Docker could be a quick fix, but I think a better long term solution may be to have config in the app to specify the machinery IP/Port this would make it easier to add multi server support to one Web instance later.

for example instead of having a proxypass to the machinery in the nginx config (https://github.com/kerberos-io/web/blob/master/docker/web.conf#L27) make this route configurable in the app/config files.

Just a thought i had.

wcomartin commented 6 years ago

@cedricve I added the two ENV vars to the web docker in the web repo, which branch would you like me to make a PR to? develop?

cedricve commented 6 years ago

perfect