search

kerberos-io / machinery

(DEPRECATED) An open source image processing framework, which uses your USB-, IP- or RPi-camera to recognize events (e.g. motion).
https://www.kerberos.io
489 stars 102 forks source link

Use of local S3 compatible service #215

Open Jacq opened 4 years ago

Jacq commented 4 years ago

Is your feature request related to a problem? Please describe. Could not find information about the possibility to config the S3 url:port.

Describe the solution you'd like To add in the configuration the host:port info for a local S3 endpoint

Describe alternatives you've considered Use S3 minio as a local storage, also Ceph s3 should be possible if the interface expected from kerberos-io is a standard S3 endpoint.

Additional context N/A.

Istar-Eldritch commented 4 years ago

After taking a look at the source code for the cloud connection implementation it seems this is currently not supported because of the way the cloud logic manages the input for the bucket value. The current implementation generates the connection URL using string concatenation in a couple lines here and here

I think a good way to go about it allowing custom connection strings while keeping backwards compatibility is to just check if the connection string starts with https and leave it as it is if that is the case, otherwise generate the correct URL format assuming the string is the bucket name.

I'm happy to open a PR implementing the previous solution as this is something I would use myself. Happy to hear from the maintainers about what are their thoughts about it.

cedricve commented 4 years ago

Hey @Istar-Eldritch correct, we are currently moving the entire project to a new architecture, and we will make this more configurable.