kercos / geomodel

Automatically exported from code.google.com/p/geomodel
0 stars 0 forks source link

Incorrect optimization #23

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Sometimes, a search will fail to bring up otherwise valid results because of 
this optimization in geomodel.py (async branch):

      # Stop the search if the next closest possible search result is farther
      # than max_distance or, if we have max_results results already, farther
      # than the last result.

this optimization is correct, but evaluated after expanding cur_geocells, which 
means that the algorithm wrongly assumes that any additional results are 
farther away than the new expanded cur_geocells and not just farther away than 
the already searched cur_geocells. See attached patch for possible fix, which 
moves the expansion logic below the optimizations.

Original issue reported on code.google.com by elias.n...@gmail.com on 25 Aug 2010 at 11:34

Attachments: