kercre123 / WirePod

Easy-to-use cross-platform builds for wire-pod.
28 stars 5 forks source link

Automate building for Windows and macOS (amd64 and arm64) when new release is created #1

Closed xiJulian closed 6 months ago

xiJulian commented 6 months ago

The macOS build script now builds for two architectures (amd64 and arm64). I've also added a GitHub Actions workflow that automatically builds and uploads Windows and macOS apps when a new release is created.

kercre123 commented 6 months ago

The macOS build fails:

Done running the AppleScript...
Fixing permissions...
Done fixing permissions
Skipping blessing on sandbox
Deleting .fseventsd
Unmounting disk image...
hdiutil: couldn't eject "disk2" - Resource busy
Wait a moment...
Unmounting disk image...
hdiutil: couldn't eject "disk2" - Resource busy
Wait a moment...
Unmounting disk image...
hdiutil: couldn't eject "disk2" - Resource busy
Error: Process completed with exit code 16.
xiJulian commented 6 months ago

@kercre123 this shouldn't happen but create-dmg is weird sometimes. could you try re-running the job?

kercre123 commented 6 months ago

Worked on the third try. I got this on the second try:

Creating dmg for arm64
Creating disk image...
Error: Process completed with exit code 1.

Maybe just needs some error handling for those two bits? Like, remove set -e from the script and make it so it repeats whenever the commands fail?

xiJulian commented 6 months ago

we can do that, or we can make the workflow automatically re-run if it fails