search

kerct / pe

0 stars 0 forks source link

Inappropriate block used in sequence diagram #16

Open kerct opened 4 years ago

kerct commented 4 years ago

For these boxes, [opt] block should be used since the [else] is empty.

image.png

nus-pe-bot commented 3 years ago

Team's Response

Bug accepted. We agree with the bug type, an also the severity as the developers are still able to fully comprehend the sequence diagram, similar to an if statement as compared to an if-else statement with an empty else block.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: From the module website,

severity.Medium: A flaw that causes occasional inconvenience to some users but they can continue to use the product.

I feel that it causes inconvenience to the developer when converting the diagram to code, or when trying to understand the diagram. With the current sequence diagram, it is unclear whether there would be another action in the [else] block, but was left out due to the minimal notation, or whether it is a wrong use of the alt block.