keredson / peewee

a small, expressive orm -- supports postgresql, mysql and sqlite
http://docs.peewee-orm.com/
MIT License
13 stars 4 forks source link

Extra `t2` while generating query #1

Closed keredson closed 8 years ago

keredson commented 8 years ago

peewee generating invalid SQL (such as in https://github.com/coleifer/peewee/issues/983) was fixed recently in this minor fork, reported previously in https://github.com/coleifer/peewee/issues/964 and potentially patched in https://github.com/coleifer/peewee/pull/969. i'm documenting this here in addition to the main site because @coleifer silently deletes comments he disagrees with: image

TL;DR version of why this is an issue: https://github.com/keredson/peewee#herman-raises-exceptions-when-invalid-columns-are-referenced

@blueset fyi

keredson commented 8 years ago

btw this appears to be a long-standing point of confusion w/ peewee. a quick search reveals:

blueset commented 8 years ago

TL;DR version of why this is an issue: https://github.com/keredson/peewee#herman-raises-exceptions-when-invalid-columns-are-referenced

Nice solution and fork!

coleifer commented 8 years ago

@keredson -- I'd appreciate it if you would please not spam my ticket tracker with links to the tickets in your fork.

I've made it very clear that I do not want you to be involved in the development of peewee. Please respect that decision. I'm happy for you to have forked the code and wish you well.

coleifer commented 8 years ago

Here's what I am talking about:

s1465965554 31

keredson commented 8 years ago

it's not spam. it's a collection of issues related by the same root cause.

if you disagree, i recommend using github's "report user" link. spam is clearly against GH's TOS and they will ban users who do so.

alternatively, if this is just some personal grudge you have against me, i recommend using the "block user" feature, and you'll never have to see me on GH again.

both of these can found on my profile page: https://github.com/keredson image