Add WatchProviders - Githubissues

kerego / tmdb_dart

The Movie DB API Client for Dart

MIT License

10 stars 7 forks source link

Add WatchProviders #16

Closed fdietze closed 2 years ago

kerego commented 2 years ago

Hi @fdietze, thanks for the PR, the changes look good and useful, however, there are two things that need to be addressed

in order to publish this to dart pub the version needs to be bumped in pubspec.yaml and some comments regarding the update should be added to changelog.md file
it is a bit unclear from Map<string, WatchProviders> what should be passed as the key, maybe a comment or some enum/separate class is needed to improve the experience

fdietze commented 2 years ago

Thank you for the feedback. I'll look into it.

Akash98Sky commented 2 years ago

To me, your implementation of WatchProviders is a bit unclear. As per TMDB docs, I found watch providers to be a different endpoint, rather than being a value of append_to_response param. Your WatchProviders model seems fine, but in order to fetch watch providers you need to create a function making get request to /movie/{movie_id}/watch/providers. I hope this might help.

fdietze commented 2 years ago

@Akash98Sky You are right, there are two ways to get the providers. One is to request them as you mentioned and the other is to include them in the Movie or TvShow details: https://www.themoviedb.org/talk/5fc9f481680be8003d18564f

This PR is only about including them in the details.

fdietze commented 2 years ago

I just rebased on master and improved a few things. I think it's ready to merge now.