Fix and Improve some parts of code

kerego / tmdb_dart

The Movie DB API Client for Dart

MIT License

10 stars 7 forks source link

Fix and Improve some parts of code #7

Closed Akash98Sky closed 4 years ago

Akash98Sky commented 4 years ago

I really inspire your work on making this package on tmdb api. I tried my best to contribute to it by fixing some error and make it work better :) Thank you.

Akash98Sky commented 4 years ago

@Kerego commit 64a58f9 is a fix for an Exception as mentioned in that commit. (Recommended merge) Other 2 commits are just to improve the quality of code, and up-to you to merge or not.

All the commits are reviewed and tested by me in a LINUX environment.

kerego commented 4 years ago

Hello @Akash98Sky, thanks for your contributions, everything looks good, however in order to deploy this to dart pub there are two more files that need updates

changelog.md (details of latest update)
pubspec.yaml (increment the version)

Akash98Sky commented 4 years ago

Ok, I'll do that.

But what should be the next version? Still a pre release version like : 0.0.10 Or a stable release as : 0.1

kerego commented 4 years ago

Thanks @Akash98Sky for your contribution. I've published the latest version to the dart pub. Regarding versioning, I would keep it below 0.1 at least until the all of the movie API is covered, and then increment the minor version as we add the Series, Actor, Discovery and other functionality. Not sure when that will happen though, as before you started contributing the project was kind of on hold, and I am not sure when I will start doing Flutter again.

Akash98Sky commented 4 years ago

You are most welcome @Kerego :)

And regarding the project maintenance, that's fine, take your time. In the mean time, if possible, I'll try to add these missing functionalities to this project. Thank you.