search

kereis / traefik-certs-dumper

Dumps Let's Encrypt certificates of a specified domain which Traefik stores in acme.json.
Apache License 2.0
129 stars 24 forks source link

Not necessary restarts? #10

Closed bartagergely closed 4 years ago

bartagergely commented 4 years ago

It it really necessary to restart the containers, even if there is no change in the certificates?

[2020-06-15T00:35:33+0000]: Clearing dumping directory
[2020-06-15T00:35:33+0000]: Dumping certificates
[2020-06-15T00:35:34+0000]: Certificate and key for 'mail.domain1.tld' still up to date, doing nothing
[2020-06-15T00:35:34+0000]: Certificate and key for 'mail.domain2.tld' still up to date, doing nothing
[2020-06-15T00:35:34+0000]: Certificate and key for 'mail.domain3.tld' still up to date, doing nothing
[2020-06-15T00:35:34+0000]: Trying to restart containers
[2020-06-15T00:35:34+0000]: Looking up container with name mailcowdockerized_postfix-mailcow_1
[2020-06-15T00:35:34+0000]: Found '2b8bf99aa16b'. Restarting now...
2b8bf99aa16b
[2020-06-15T00:35:37+0000]: Restarting container '2b8bf99aa16b' was successful
[2020-06-15T00:35:37+0000]: Looking up container with name mailcowdockerized_dovecot-mailcow_1
[2020-06-15T00:35:37+0000]: Found '0c93c377595b'. Restarting now...
0c93c377595b
[2020-06-15T00:35:43+0000]: Restarting container '0c93c377595b' was successful
[2020-06-15T00:35:43+0000]: Looking up container with name mailcowdockerized_nginx-mailcow_1
[2020-06-15T00:35:43+0000]: Found '95c7718b7f28'. Restarting now...
95c7718b7f28
[2020-06-15T00:35:47+0000]: Restarting container '95c7718b7f28' was successful
[2020-06-15T00:35:47+0000]: Container restarting process done.
kereis commented 4 years ago

Yep, it isn't. I'm sorry for that. I'll try to start working on it as soon as I can. :)

kereis commented 4 years ago

Pull request #11 was created to encounter this issue. Should be fixed with the next version: 👍

kereis commented 4 years ago

Fix has been merged. I'm sorry for the delay. I'm currently busy with some other stuff. I'll create a release later this day.

Thank you for reporting this issue. 👍