keretus / sfe

Other
32 stars 7 forks source link

Updated Source + Suggestions #5

Open SK83RJOSH opened 2 years ago

SK83RJOSH commented 2 years ago

Hey Keretus,

Since this is a fork of an open source project and you've been handling all the maintenance yourself... maybe it would be a good time to open source this properly and keep this repository up to date? I'm asking because the original project relied on hardcoded addresses and etc, and SFE would benefit greatly from using modern techniques like signature scanning, automatic bindiffing, etc. This stuff is hard to do, but projects like Dalamud for FFXIV have proven that a community effort can make this stuff a breeze and that it doesn't necessarily hurt the game's security or the projects stability.

That said, I personally would love to help make this more project resilient to breaking changes by implementing some of this; especially now that Bethesda has announced their 5 year plan which likely means future engine upgrades are going to happen at some point. It would be better to get started on modernizing and fixing this stuff up now rather than later. Just my two cents. 👍

JustPyrrha commented 5 months ago

+1 for updating the source here. Additionally I've been in contact with ianpatt, the creator of f4se, who mentioned that permission for this fork was granted on the condition that the source was made public.