keriwarr / orangejoos

JOOS1W Compiler, written in Crystal
0 stars 1 forks source link

Catch a few more method modifiers cases #59

Closed keriwarr closed 6 years ago

lgo commented 6 years ago

How many +s?

lgo commented 6 years ago

wait what I thought the commit checking for all abstract implementations was already in? Is this for something else/elsewhere?

keriwarr commented 6 years ago

like +3 ?

keriwarr commented 6 years ago

re checking for abstract: yea, the diff is actually just really confusing. But tl;dr, I'm now catching a larger set of abstract implementation cases

lgo commented 6 years ago

👍 sgtm