search

keriwarr / splitwise

A JavaScript SDK for the Splitwise API.
MIT License
70 stars 18 forks source link

only enables access to a single user's content #22

Closed goleary closed 4 years ago

goleary commented 5 years ago

I'm trying to build a web app that makes use of Splitwise's API to be able to create debts for users of my app. It appears as though using a client secret is required, so I can't use their API from my client side application. I'm implementing a server layer to do the communication with Splitwise's API for this reason and their website points to this library.

I'm attempting to use firebase functions for my server layer as such: image

Whenever I hit this endpoint I get data from my account returned even though at no point was i shown an authorization screen. This is the case no matter which device I hit my endpoint from.

Is it the case that this library only provides access to the developers data? and that I can't enable users to access their own data through this library?

keriwarr commented 5 years ago

Is it the case that this library only provides access to the developers data?

@goleary I'm sorry to say that that is the case. I didn't get around to implementing all the oauth grant types. You will need to access the API directly for that purpose.

goleary commented 5 years ago

good to know. It would be awesome if info to that effect was included in the readme. I spent quite a bit of time messing with this library only to realize it wouldn't meet my needs. Kind of surprised the splitwise docs give this lib a shout out given its limitations. I can submit a PR with this clarification if you're cool with it.

keriwarr commented 5 years ago

sure.

2019年11月14日(木) 0:47 goleary notifications@github.com:

good to know. It would be awesome if info to that effect was included in the readme. I spent quite a bit of time messing with this library only to realize it wouldn't meet my needs. Kind of surprised the splitwise docs give this lib a shout out given its limitations. I can submit a PR with this clarification if you're cool with it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/keriwarr/splitwise/issues/22?email_source=notifications&email_token=ABJVBMEFBYMPPIRCWR7ZHPDQTTQ5TA5CNFSM4JND2QTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEAVIEI#issuecomment-553735185, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJVBMHOCLR75RXHZSHJXVTQTTQ5TANCNFSM4JND2QTA .