lwille commented 4 years ago

Since they introduced deleting and undeleting expenses, this library always returns all expenses unless you set visible=true.

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files           6        6           
  Lines         245      245           
  Branches       47       47           
=======================================
  Hits          183      183           
  Misses         48       48           
  Partials       14       14

Impacted Files	Coverage Δ
src/splitwise.js	`60.50% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd74b58...e329c6a. Read the comment docs.

lwille commented 4 years ago

@keriwarr is this project still maintained?

keriwarr commented 4 years ago

@lwille hey thanks for the pull request! I accidentally dismissed the first notification

keriwarr commented 4 years ago

hmm travis seems to be not working. I'm going to close and re-open

keriwarr commented 4 years ago

I will deal with this later 😆 , thanks again

keriwarr / splitwise

fix: add `visible` parameter to `get_expenses` call #25

Codecov Report