kermitt2 / entity-fishing

A machine learning tool for fishing entities
http://nerd.readthedocs.io/
Apache License 2.0
246 stars 24 forks source link

Linking wikipedia/wikidata with only ‘ner’ #125

Closed aa303554 closed 2 years ago

aa303554 commented 3 years ago

When only the ner parameter is used in mentions, we still get some links to wikidata/Wikipedia, but with a different visual representation.

image

See ‘Suisse’ and ‘Ludlow’ in the example below.

image

Yet in the json, "Ludlow" and "Suisse" are similar.

How can there be a Wikipedia/Wikidata link without using the wikipedia parameter in mentions ?

kermitt2 commented 3 years ago

Hi @aa303554 !

See the documentation, the mentions refers to the step of collecting terms to be disambiguated:

Then all these terms are disambiguated against Wikipedia, so the "linking" is always present but for a different set of terms of interest. mentions simply define how to select terms which will be "linked".

If it appears unclear, would it be a way to clarify the documentation?

kermitt2 commented 2 years ago

I am closing the issue - as it is answered by the documentation. Feel free to re-open it if you still have some doubts or if you think it's possible to improve the documentation.