search

kermitt2 / grobid

A machine learning software for extracting information from scholarly documents
https://grobid.readthedocs.io
Apache License 2.0
3.6k stars 461 forks source link

Adjust circuit-breaker for #1113 #1125

Closed lfoppiano closed 5 months ago

lfoppiano commented 5 months ago

In the fix for #1113:

https://github.com/kermitt2/grobid/blob/83f2c81a3580c052697ffb46949dfec3deb67f32/grobid-core/src/main/java/org/grobid/core/document/TEIFormatter.java#L1614

if the URL is at beginning of the sentence/paragraph, it's normal to have both pos and matchingPosition.start) == 0, which should not cause any trouble (the string before will be empty).

This PR updates the >= with >. 😅

coveralls commented 5 months ago

Coverage Status

coverage: 40.787%. remained the same when pulling c5c924ec480a765967a5d489d86718b3441b4a39 on bugfix/fix-links-beginning-sent into 694f0ed055e8c9a5d5efdc314ebef78e5e2640cf on master.