search

kermitt2 / grobid_client_python

Python client for GROBID Web services
Apache License 2.0
279 stars 75 forks source link

Cannot be imported as package #14

Closed bjrne closed 2 years ago

bjrne commented 3 years ago

Thanks for going through the trouble to also provide an asynchronous example client for grobid!

In order to use the code in existing python programs through import statements filenames must not contain dashes, as well as the folder/module name. It's actually only a tiny code change, so I have already pushed a PR for easier discussion. However, the repo itself would also need a renaming since its name also contains dashes.

kermitt2 commented 3 years ago

Thank you @bjrne !

Indeed, as written here the client is a bit half done ;)

I will go through the process you propose in the next days, thanks.

kermitt2 commented 2 years ago

This is implemented by #26

bjrne commented 2 years ago

I haven't tested it again myself, but that sounds like this is ready to be closed :bee: