search

kermitt2 / grobid_client_python

Python client for GROBID Web services
Apache License 2.0
275 stars 74 forks source link

Add segment sentences flag #36

Closed reppertj closed 2 years ago

reppertj commented 3 years ago

I needed to add a --segment_sentences flag to the CLI/process functions. It's a quick change that I've already made locally, LMK if you'd like a PR!

kermitt2 commented 3 years ago

Hello @reppertj ! This is already in PR https://github.com/kermitt2/grobid_client_python/pull/32 I am waiting for feedback on the process reference list action to merge, but if you have a chance too to test the --segmentSentences option in the PR, thanks in advance (note: so far name of the CLI options mirrors the Grobid API paramters, thus rather --segmentSentences than --segment_sentences for consistency).

reppertj commented 3 years ago

Ah, sounds good! I'll give it a try, but the changes in the PR look simple enough!

bnewbold commented 2 years ago

Looks like this issue can be closed