search

kermitt2 / kish

Keeping It Simple is Hard
9 stars 5 forks source link

does validating a document before validating an annotation save it or not? #3

Open jameshowison opened 1 year ago

jameshowison commented 1 year ago

In using the system I clicked on a sentence, ten gave it a code of "software/implicit". I then finished reading the PDF and hit "validate document". Then I noticed the green "validate" button for the annotation (or maybe it's for the selection).

If I validate the document but haven't yet validated a annotation, wasn't clear to me if the annotation got saved.

kermitt2 commented 1 year ago

In the current version, if the annotation is not validated (validated means committed on server), it is lost. If you select again the same sentence without having it validated, it is a selection from scratch to be annotated again.

Certainly an improvement would be to save in local browser storage the non validated sentences/annotations, and when the document is validated ask the user if every "non-validated" annotations should be validated/saved too.

Note that it 's is fine to validated all the time, every sentences/annotations can be updated later.

jameshowison commented 1 year ago

Got it thanks!

On Thu, Mar 30, 2023 at 6:25 AM Patrice Lopez @.***> wrote:

In the current version, if the annotation is not validated (validated means committed on server), it is lost. If you select again the same sentence without having it validated, it is a selection from scratch to be annotated again.

Certainly an improvement would be to save in local browser storage the non validated sentences/annotations, and when the document is validated ask the user if every "non-validated" annotations should be validated/saved too.

Note that it 's is fine to validated all the time, every sentences/annotations can be updated later.

— Reply to this email directly, view it on GitHub https://github.com/kermitt2/kish/issues/3#issuecomment-1490133861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWOUUYXNLLFEZG6PNDVDDW6VURHANCNFSM6AAAAAAWMQCQR4 . You are receiving this because you authored the thread.Message ID: @.***>