Closed andytudhope closed 2 years ago
@andytudhope can you post some screenshots of how the pages look now? in the PR description
I think we wanted to have the common images directory be either
common/assets/images
orcommon/src/assets/images
-- deferring to @simonkernel here but I think anassets
directory goes somewhere smile
You are correct that was our initial thinking.
Having said that, I'm fine going with images
for now since it's the only asset we have.
We can always move it later and it shouldn't impact the dependent apps since they're importing the common
package and are not concerned about the internal organization of the commons package itself.
I'll leave it up to @andytudhope and @rorysaur to make the call :grin:
Yeah, no strong preference re: assets
directory and we can always change it later. One small plus is that if it's consistently src/assets/images
it might be less mental overhead.
This PR does a few things:
It does not attend to many of the thoughts outlined in #20 because I think we need to discuss those further and think more deeply about what to do and how to represent things once someone has created a wallet.
I do agree that we should rename the page you land on from
assets
to something that is still generic, but less overtly financial.