adding solid foothold to build upon

youami commented 2 years ago

Closes #19

Footer component refactored:

If Footer has children those are rendered as is. If footerLinks are provided on Footer they are ignored.
If Footer has no children, one can use footerLinks to pass an array of objects each containing app which is the subdomain to create a link with and title.
If Footer has no children and no footerLinks are provided, default footerLinks are used which currently include the links to 'explorer', 'unprofile', 'adventures', 'portal'.

Kernel_Explorer

Additional changes:

getUrl function is now available in common which get the app name as a param and returns the full URL for the corresponding env.

youami commented 2 years ago

Thanks for the detailed review and comments @rorysaur! Refactored and pushed.

yarn format didn't work for me, but npx standard --fix did. I staged only the files I touched so I hope this will resolve the build issue. If not would be happy to sync on how to make it correctly.

rorysaur commented 2 years ago

PS. Non-blocking, but as a favor, if you could rewrite the code in the wallet homepage to use the new getUrl, that would be perfect: https://github.com/kernel-community/services/blob/main/packages/wallet/src/views/Home.jsx#L16 https://github.com/kernel-community/services/blob/main/packages/wallet/src/views/Home.jsx#L80

youami commented 2 years ago

@rorysaur added separate commits for the changes per your comments and another one for the change in wallet home. I hope that I got the linting right this time :)

kernel-community / services

adding solid foothold to build upon #29