search

kernelci / kernelci-backend

Upstream Linux Kernel Validation Project API
http://api.kernelci.org
GNU Lesser General Public License v2.1
40 stars 27 forks source link

T25891 Change status to SKIP when pushing UNKOWN status to kcidb #276

Closed mgalka closed 3 years ago

mgalka commented 3 years ago

kcidb doesn't accept 'UNKNOWN' status of the test as a valid value. This leads to an error and data not being uploaded to kcidb The closes we can get is changing the status to 'SKIP'.

gctucker commented 3 years ago

Seems fair enough.

@mgalka Please check in the logs if the validation is now accepting all the data being sent.

gctucker commented 3 years ago

Saw this in the backend logs:

Jan 25 16:59:59 kernelci-staging kernelci-celery[18385]: jsonschema.exceptions.ValidationError: None is not of type 'object'
Jan 25 16:59:59 kernelci-staging kernelci-celery[18385]: Failed validating 'type' in schema['properties']['tests']['items']['properties']['misc']:
Jan 25 16:59:59 kernelci-staging kernelci-celery[18385]:     {'description': 'Miscellaneous extra data about the test run',
Jan 25 16:59:59 kernelci-staging kernelci-celery[18385]:      'type': 'object'}
gctucker commented 3 years ago

I believe the error above was with the version of this PR before the last push, so we'll see later today if the errors go away.

gctucker commented 3 years ago

Still seeing this exception:

Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:   File "/usr/lib/python3/dist-packages/jsonschema/validators.py", line 130, in validate
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     raise error
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: jsonschema.exceptions.ValidationError: None is not of type 'object'
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: Failed validating 'type' in schema['properties']['tests']['items']['properties']['misc']:
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     {'description': 'Miscellaneous extra data about the test run',
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:      'type': 'object'}
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: On instance['tests'][0]['misc']:
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     None

So adding staging-skip for now as it looks like this is the reason why there haven't been any test results on staging since last night.

mgalka commented 3 years ago

Still seeing this exception:

Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:   File "/usr/lib/python3/dist-packages/jsonschema/validators.py", line 130, in validate
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     raise error
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: jsonschema.exceptions.ValidationError: None is not of type 'object'
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: Failed validating 'type' in schema['properties']['tests']['items']['properties']['misc']:
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     {'description': 'Miscellaneous extra data about the test run',
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:      'type': 'object'}
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]: On instance['tests'][0]['misc']:
Jan 26 07:31:26 kernelci-staging kernelci-celery[23713]:     None

So adding staging-skip for now as it looks like this is the reason why there haven't been any test results on staging since last night.

I've already push a patch that fixes this issue. I'll test it on my local setup and paste results.

gctucker commented 3 years ago

OK there's another issue on staging preventing jobs to be started at all, that also explains where there's no results. Once that has been fixed, this PR can be enabled again and we should be able to verify the exception is gone.