RFC: vars/buildImage: staging -> production

[khilman]

@gctucker You've already done some work in unifying tokens between staging and master. Is there a better way to do this so we have a job that works on both staging and production?

[gctucker]

Hi @khilman, @ana, I've put some review comments on the changes. Essentially I've been using standard Jenkins job parameters for that, so the jobs can be set up on any Jenkins server with different default values. It also allows manual runs with alternative values, say if you want to try something with a different backend.

The downside is that the number of parameters can grow quite quickly, so it can be a bit harder to manage than a config file, but it's working well enough for now. In the future, we may just have one parameter with a URL where the job would fetch a config file from (or git clone a config repo).

[ana]

I'd love to avoid using jenkins job parameters but I don't see a better option for now. In the near future, the idea of using a single job parameter with an URL is very worth pursuing, we should look at this when we eventually consolidate all the jenkins pipelines code.

[khilman]

@ana can you follow up with this and propose some changes using jenkins job parameters that will work in both production and staging?

[ana]

Yes, I'll take care of this.

[ana]

@khilman you can close this now.

[khilman]

Was this fixed somewhere else?

[ana]

Yes, with https://github.com/kernelci/kernelci-build-staging/pull/36

[khilman]

ok