search

kernelci / kernelci-core

Core KernelCI tools
https://kernelci.org
GNU Lesser General Public License v2.1
99 stars 96 forks source link

base/lava.jinja2: Add instance_callback retrieved from environment #2603

Closed nuclearcat closed 3 days ago

nuclearcat commented 3 days ago

Right now we define callback URL for LAVA labs in config, which doesn't make sense, as this URL is pipeline instance specific, and complicates deployment of staging vs production instances. It is better to define callback URL as environment variable, for now.

nuclearcat commented 3 days ago

Tested on staging

JenySadadia commented 3 days ago

As per the discussion, alternatively, we can think about using TOML file to define this variable later on.