search

kernelci / kernelci-core

Core KernelCI tools
https://kernelci.org
GNU Lesser General Public License v2.1
107 stars 97 forks source link

config: build_board: Include data directory in tast archive #2662

Closed musamaanjum closed 2 months ago

musamaanjum commented 2 months ago

Tests can register ancillary data files that will be copied to the DUT and made available while the test is running.

The tast archive (tast.tgz) doesn't have the small data files. Copy all of the data files to this archive. There is a specific path for these data files inside /usr/share/tast/data/go.chromium.org. Copy go.chromium.org directory into the archive, so that the same directory can be placed at correct path in lava tast container.

I've got errors for storage.HealthInfo test where 13 data files are missing: 2024-08-16T19:18:03.352903Z [19:18:03.352] Error at entity.go:34: Required data file seq_read missing 2024-08-16T19:18:03.352931Z [19:18:03.352] Error at entity.go:34: Required data file seq_write missing 2024-08-16T19:18:03.352982Z [19:18:03.352] Error at entity.go:34: Required data file tbw_probe missing

Instead of copying only these 13 files, I've decided to copy the entire data directory as it'll help us in solving similar issues for other test failures which we don't know yet at this time. Also it is under 7 MB which isn't much considering the size of tast archive which is already over 40-50 MB.

Signed-off-by: Muhammad Usama Anjum usama.anjum@collabora.com

musamaanjum commented 2 months ago

@nuclearcat @a-wai We need to regenerate Chromeos artifacts for all boards. Do we use https://github.com/kernelci/kernelci-core/actions/workflows/rootfs.yml for this purpose or do we have a separate CI for generating these?

10ne1 commented 2 months ago

LGTM, I'll leave the others who are the code owners to approve.

a-wai commented 2 months ago

The change LGTM, although IIRC it should target the chromeos branch.

We need to regenerate Chromeos artifacts for all boards.

Unless things changed lately this has to be done manually.

musamaanjum commented 2 months ago

The change LGTM, although IIRC it should target the chromeos branch.

Corrected the target branch to chromeos.

We need to regenerate Chromeos artifacts for all boards.

Unless things changed lately this has to be done manually.

@a-wai @nuclearcat Please someone generate them.

10ne1 commented 2 months ago

I think this can be closed, the change landed as part of #2678