config: rt-tests: fix MLOCKALL getting set to True

[musamaanjum]

When MLOCKALL is set to 'true', the lava job has MLOCKALL becomes true [1] which in turn translates to "True" while job execution [2]. It causes error as the test expects true instead of True.

./pi-stress.sh -D 60s -m True -r false -w hackbench ./pi-stress.sh: 37: True: not found

Fix it by using double quotes instead.

[1] https://lava.collabora.dev/scheduler/job/15562666/definition#defline43 [2] https://lava.collabora.dev/scheduler/job/15562666#L220

[musamaanjum]

Let's confirm from the execution results if this works.

[musamaanjum]

This fix didn't work: https://lava.collabora.dev/scheduler/job/15747114

@pawiecz please can you help solve this issue? In job (https://lava.collabora.dev/scheduler/job/15747239), I've manually added double quotes around true and job worked fine.

[musamaanjum]

This fix didn't work: https://lava.collabora.dev/scheduler/job/15747114

@pawiecz please can you help solve this issue? In job (https://lava.collabora.dev/scheduler/job/15747239), I've manually added double quotes around true and job worked fine.

@pawiecz Please have a look.

[pawiecz]

Also: timeout for this test suite has to be extended to provide some buffer for initialization - it shouldn't be equal to the requested test duration.

[musamaanjum]

Also: timeout for this test suite has to be extended to provide some buffer for initialization - it shouldn't be equal to the requested test duration.

@pawiecz we had probably discussed this in some meetings that it is okay to have the same timeouts. Or I may be mistaken. Currently, the total test duration is set to 10 minutes and the test's execution is also set to 10 minutes. Should we reduce the test duration by 30 or 60 seconds?

[musamaanjum]

Result: https://lava.collabora.dev/scheduler/job/15790240

@nuclearcat let's merge this PR.

[pawiecz]

Also: timeout for this test suite has to be extended to provide some buffer for initialization - it shouldn't be equal to the requested test duration.

@pawiecz we had probably discussed this in some meetings that it is okay to have the same timeouts. Or I may be mistaken. Currently, the total test duration is set to 10 minutes and the test's execution is also set to 10 minutes.

Let me give an example:

• timeout "countdown" starts when TestAction begins
• test execution starts after:
  • logging in
  • setting the environment
  • triggering test runner script

Due to these slight delays it might not be able to finish successfully. Providing a slight margin (e.g. 11 minutes instead of 10 for a test expected to go for 10 minutes) could reduce flakiness

Should we reduce the test duration by 30 or 60 seconds?

I'm not sure how long this test case should run to provide meaningful results :cry: