search

kernelhcy / gtkqq

a qq client based on gtk+ uses webqq protocol
http://code.google.com/p/gtk-qq/
GNU General Public License v3.0
181 stars 42 forks source link

change notify_notification_new() parameter #71

Closed billzt closed 12 years ago

billzt commented 12 years ago

notify_notification_new() 最好只要三个参数，否则在许多发行版如 Ubuntu 11.10 上无法通过编译。

这是对 commit 05f1c712a2423158e4b7e4079c65215eae65e2e8 的再现

shwangdev commented 12 years ago

在我的knoppix上需要四个参数。 请把你的版本号写上来。 On Sun, Feb 12, 2012 at 9:26 AM, billzt < reply@reply.github.com

wrote:

notify_notification_new() 最好只要三个参数，否则在许多发行版如 Ubuntu 11.10 上无法通过编译。

这是对 commit 05f1c712a2423158e4b7e4079c65215eae65e2e8 的再现

You can merge this Pull Request by running:

git pull https://github.com/billzt/gtkqq dev

Or you can view, comment on it, or merge it online at:

https://github.com/kernelhcy/gtkqq/pull/71

-- Commit Summary --

  • change notify_notification_new() parameter

-- File Changes --

M src/gui/notify.c (2)

-- Patch Links --

https://github.com/kernelhcy/gtkqq/pull/71.patch https://github.com/kernelhcy/gtkqq/pull/71.diff

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*

billzt commented 12 years ago

@wxjeacen 请问是什么的版本号？该怎么找版本号？

shwangdev commented 12 years ago

notify_notification_new()

应该是libnotify的版本号

On Sun, Feb 12, 2012 at 6:34 PM, billzt < reply@reply.github.com

wrote:

@wxjeacen 请问是什么的版本号？该怎么找版本号？

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71#issuecomment-3926958

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*

billzt commented 12 years ago

@wxjeacen libnotify-dev, 0.7.4-1, 这是 Ubuntu 11.10

http://developer.gnome.org/libnotify/0.7/NotifyNotification.html ，里面有说明的

NotifyNotification * notify_notification_new (const char summary, const char body, const char *icon);

shwangdev commented 12 years ago

我的版本是0.5.x 是有四个参数的。 那我们需要在configure.ac里面统一下libnotify的版本。

On Sun, Feb 12, 2012 at 6:38 PM, billzt < reply@reply.github.com

wrote:

@wxjeacen libnotify-dev, 0.7.4-1, 这是 Ubuntu 11.10

http://developer.gnome.org/libnotify/0.7/NotifyNotification.html ，里面有说明的

NotifyNotification * notify_notification_new (const char summary, const char body, const char *icon);

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71#issuecomment-3926980

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*

billzt commented 12 years ago

@wxjeacen 嗯，那怎么统一？不同发行版的版本肯定不一样

billzt commented 12 years ago

建议分不同的版本分别对待吧

ekd123 commented 12 years ago

其实libnotify没法共存的。。。用 LIBNOTIFY_CHECK_VERSION 就可以了，参考我很久以前给 iceplayer 写的那个 patch，已经 merge 的。

shwangdev commented 12 years ago

我觉得应该announce libnotify 的版本在configure.ac里面。 直接定义在0.7.x以上。 On Mon, Feb 13, 2012 at 1:53 PM, Mike Manilone < reply@reply.github.com

wrote:

其实libnotify没法共存的。。。用 LIBNOTIFY_CHECK_VERSION 就可以了，参考我很久以前给 iceplayer 写的那个 patch，已经 merge 的。

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71#issuecomment-3934818

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*

billzt commented 12 years ago

@wxjeacen 不行吧，这样子老版本用户又没法使用了，你自己不也是 0.5.x 吗？

shwangdev commented 12 years ago

我已经升级到0.7.x了 我不觉得support old 版本的lib是我们的开发理念。 Providing the latest open source technologies in an elegant format 才是Geek的精神。

On Mon, Feb 13, 2012 at 2:00 PM, billzt < reply@reply.github.com

wrote:

@wxjeacen 不行吧，这样子老版本用户又没法使用了，你自己不也是 0.5.x 吗？

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71#issuecomment-3934862

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*

billzt commented 12 years ago

@wxjeacen 但是 qq 不只是给 geek 用的，而是给老百姓用的，应该考虑到他们的需求。建议使用 @ekd123 的提议

shwangdev commented 12 years ago

虽然很不情愿，但是我已经加了。 linuxer首先应该是贡献，然后才是索取。普通用户怎么了。 我觉得GTKQQ的目标应该是往入源靠拢。 user可以直接一个命令把依赖都装上。 On Mon, Feb 13, 2012 at 2:33 PM, billzt < reply@reply.github.com

wrote:

@wxjeacen 但是 qq 不只是给 geek 用的，而是给老百姓用的，应该考虑到他们的需求。建议使用 @ekd123 的提议

Reply to this email directly or view it on GitHub: https://github.com/kernelhcy/gtkqq/pull/71#issuecomment-3935093

*

Best Regards, **

Xiang Wang| Engineer of Linux

Gtalk: wxjeacen AT gmail DOT com wxjeacen@gmail.com

*