Upgrade NETCONF Client from 2.2.0 to 3.1.1

[axkar]

Refactor NETCONF functions (get_data) to accommodate the upgrade in the netconf_client library within the Docker container image.

Other information

Checklist

Tick relevant boxes, this PR is-a or has-a:

• [ ] Bugfix
  • [ ] Regression tests
  • [ ] ChangeLog updates (for next release)
• [ ] Feature
  • [ ] YANG model change => revision updated?
  • [ ] Regression tests added?
  • [ ] ChangeLog updates (for next release)
  • [ ] Documentation added?
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (please detail in commit messages)
• [ ] Build related changes
• [ ] Documentation content changes
• [ ] Other (please describe):

[axkar]

It is probably easier to ask and comment here in the PR than in the issue #390 @troglobit @mattiaswal I have a question regarding get_config in netconf.py.

I think we should not leverage _get for that since it is used to fetch both operational and running (all config). ncc.get_config allows for specifying source (datastore), as far as I see in netconf_client.

see: https://github.com/ADTRAN/netconf_client/blob/main/netconf_client/ncclient.py https://github.com/ADTRAN/netconf_client/blob/main/netconf_client/rpc.py

[troglobit]

@ahmkar94 not sure I follow?

The method infamy/netconf.py:_get() is (and should!) only used locally in the Class by get() and get_config(). You are free to refactor infamy/netconf.py any way you see fit to reduce the amount of extra code we have to make future upgrades of ncclient easier :smiley: :hammer_and_wrench:

[axkar]

@ahmkar94 not sure I follow?

The method infamy/netconf.py:_get() is (and should!) only used locally in the Class by get() and get_config(). You are free to refactor infamy/netconf.py any way you see fit to reduce the amount of extra code we have to make future upgrades of ncclient easier 😃 🛠️

I meant that as you said _get is used by both get() and get_config(), but _get does not allow for the source parameter to be passed when get_config is used as a getter function.This way get_config will always fetche the default (running configuration) when calling it (as far as I understand) :)

def get_config(self, source="running", filter=None, with_defaults=None):

[axkar]

But I can make an additional commit for that anyways and we see then :)

[troglobit]

I can checkout your branch and push a new infamy docker image.

Container image updated to v2.0 on ghcr.io:

https://github.com/kernelkit/infix/pkgs/container/infix-test/283471275?tag=2.0

So you can restart your actions to get the tests working.

[axkar]

I can checkout your branch and push a new infamy docker image.

Container image updated to v2.0 on ghcr.io:

https://github.com/kernelkit/infix/pkgs/container/infix-test/283471275?tag=2.0

Thnx!

[troglobit]

I meant that as you said _get is used by both get() and get_config(), but _get does not allow for the source parameter to be passed when get_config is used as a getter function. This way get_config will always fetche the default (running configuration) when calling it (as far as I understand) :)

OK. Sometimes upgrading/replacing our own wrappers is not a 1:1 mapping to new upstream APIs, this may lead to more or less work to refactor in several steps.

[troglobit]

But I can make an additional commit for that anyways and we see then :)

Yes, please submit a proposal. Much easier to discuss around code :-)