Misc interface dhcp

[troglobit]

Description

Mixed bag of fixes and changes.

• Clarify relationship between DHCP option 3 and 121 in test and doc (@jovatn + @axkar)
• Add support for setting interface ifAlias using the YANG interface description (@ all)
• Sync developer's guide and contributing guidelines (@jovatn)
• Fix regression in RAUC compatible string (@wkz)

Checklist

Tick relevant boxes, this PR is-a or has-a:

• [ ] Bugfix
  • [ ] Regression tests
  • [ ] ChangeLog updates (for next release)
• [x] Feature
  • [ ] YANG model change => revision updated?
  • [x] Regression tests added?
  • [x] ChangeLog updates (for next release)
  • [x] Documentation added?
• [x] Test changes
  • [x] Checked in changed Readme.adoc (make test-spec)
  • [x] Added new test to group Readme.adoc and yaml file
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (please detail in commit messages)
• [ ] Build related changes
• [x] Documentation content changes
  • [ ] ChangeLog updated (for major changes)
• [ ] Other (please describe):

[troglobit]

Great! I added some comments to the DHCP Routes test. Feel free to ignore them, but check specifically one of the test steps if "has a" should be changed to "does not have a".

Thanks! I'd already started revising them after our chat yesterday, but I'll definitely have a look and see what I can incorporate. :smiley:

[troglobit]

Great! I added some comments to the DHCP Routes test. Feel free to ignore them, but check specifically one of the test steps if "has a" should be changed to "does not have a".

Thanks! I'd already started revising them after our chat yesterday, but I'll definitely have a look and see what I can incorporate. 😃

There, maybe you can have a look again, @jovatn?

[troglobit]

Ping @wkz, re: another compatible string fix, third time's the charm ... I hope.

[troglobit]

Perhaps the dhcp_routes/Readme.adoc file is not updated?

Ah, great catch, thanks!

[troglobit]

Great cleanup, some comments on ifalias.

Awesome, I'll have a look!