search

kernelkit / infix

Linux :yellow_heart: NETCONF = Infix
https://kernelkit.org
GNU General Public License v2.0
52 stars 12 forks source link

OSPF 'address-family' setting should not be listed #813

Open jovatn opened 1 week ago

jovatn commented 1 week ago

Current Behavior

In OSPF(v2) context there exist an "address-family" setting, but it does not make sense to have it as we only support OSPF for IPv4 routes.

admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> set ?
  address-family           Address family of the instance.
  area                     List of OSPF areas.
  default-route-advertise  Distribute default route to network
  explicit-router-id       Defined in RFC 2328.  A 32-bit number
  redistribute             Redistribute protocols into OSPF
admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> set

Adding a not-supported deviation for the address-family setting in infix-routing.yang should do the trick ...

Expected Behavior

The address-family setting should not be visible in CLI (and not possible to set via sysrepocfg, etc.)

admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> set ?
  area                     List of OSPF areas.
  default-route-advertise  Distribute default route to network
  explicit-router-id       Defined in RFC 2328.  A 32-bit number
  redistribute             Redistribute protocols into OSPF
admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> set

Steps To Reproduce

  1. Run any infix release with OSPF support included, e.g., 24.10.1
  2. List global OSPF settings as shown above.

Additional information

Additional information on the address-family setting from the CLI.

admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> help address-family 
NAME
        address-family <enum>

DESCRIPTION
        Address family of the instance.

admin@example:/config/routing/control-plane-protocol/ospfv2/name/default/ospf/> set address-family ?
  appletalk              Apple AppleTalk Address Family.
  as-num                 Autonomous System (AS) Number Address Family.
  bbn1822                Bolt, Beranek, and Newman Report 1822 (BBN 1822)
  bgp-ls                 Border Gateway Protocol - Link State (BGP-LS)
  decnet-iv              Digital Equipment DECnet Phase IV Address Family.
  distinguished-name     Distinguished Name Address Family.
  dns                    Domain Name System (DNS) Address Family.
  e163                   ITU-T E.163 Address Family.
  e164                   ITU-T E.164 (Switched Multimegabit Data Service (SMDS),
  e164-nsap              ITU-T E.164 with NSAP sub-address Address Family.
  eigrp-common-sf        Enhanced Interior Gateway Routing Protocol (EIGRP)
  eigrp-v4-sf            EIGRP IPv4 Service Family Address Family.
  eigrp-v6-sf            EIGRP IPv6 Service Family Address Family.
  f69                    ITU-T F.69 (Telex) Address Family.
  fc-node                FC World-Wide Node Name Address Family.
  fc-port                Fibre Channel (FC) World-Wide Port Name Address Family.
  gwid                   ATM Gateway Identifier (GWID) Number Address Family.
  hdlc                   High-Level Data Link Control (HDLC) Address Family.
  ieee802                IEEE 802 Committee Address Family
  ipv4                   IPv4 Address Family.
  ipv6                   IPv6 Address Family.
  ipv6-64                First 8 octets (64 bits) of IPv6 address
  ipx                    Novell Internetwork Packet Exchange (IPX)
...
...