search

kernelsauce / turbo

Turbo is a framework built for LuaJIT 2 to simplify the task of building fast and scalable network applications. It uses a event-driven, non-blocking, no thread design to deliver excellent performance and minimal footprint to high-load applications while also providing excellent support for embedded uses.
http://turbo.readthedocs.io/
Apache License 2.0
528 stars 84 forks source link

Websocket Protocol is not implemented for Big-Endian Systems #268

Open santhosh-tekuri opened 8 years ago

santhosh-tekuri commented 8 years ago

see: https://github.com/kernelsauce/turbo/blob/master/turbo/websocket.lua#L259 https://github.com/kernelsauce/turbo/blob/master/turbo/websocket.lua#L322

following functions needs to be implemented for Big-Endian Systems:

function websocket.WebSocketStream:_frame_len_16(data)
function websocket.WebSocketStream:_frame_len_64(data)
function websocket.WebSocketStream:_send_frame(finflag, opcode, data)

I think implementing for BE should be easier than LE as BE is the network-byte order

kernelsauce commented 8 years ago

Yep, I was hoping nobody were using BE ;) (are you?). I will fix this. Its a small thing.

santhosh-tekuri commented 8 years ago

yes. we are using it ppc which is BE

santhosh-tekuri commented 8 years ago

any update on this ?

kernelsauce commented 8 years ago

Nope. Im on vacation.

man. 18. jul. 2016 kl. 07.41 skrev Santhosh Kumar Tekuri < notifications@github.com>:

any update on this ?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/kernelsauce/turbo/issues/268#issuecomment-233231854, or mute the thread https://github.com/notifications/unsubscribe-auth/ABCBmmQ5giZ1Q7-PK3-Iv1DY_SVy_3Flks5qWxIBgaJpZM4JJFbU .

Mvh / Best regards John Abrahamsen Tlf/Phone: (+47) 941 35 009

santhosh-tekuri commented 8 years ago

any update on this ?

kernelsauce commented 8 years ago

Yes, I will implement it in the next couple weeks :).