search

kernelwernel / VMAware

VM detection library and tool
MIT License
351 stars 38 forks source link

Not an issue, just needing assistance. #2

Closed eyjafjallajo closed 12 months ago

eyjafjallajo commented 1 year ago

Trying to compile vmaware.hpp with MSVC 2019 16.7 on c++11 standard causes total of 30 issues. 7 out of 30 issues for example: inline variable asks for c++17. How to compile vmaware.hpp on c++11?

kernelwernel commented 1 year ago

I'll try to fix that asap. I didn't think anybody would use C++11, but I knew about the warnings prior to claiming it's C++11 compatible. I figured if it's still compilable even with the warnings, I didn't think it was a major problem.

Thanks for pointing that out though, I'll work on it right now.

eyjafjallajo commented 1 year ago

Thank you!

kernelwernel commented 12 months ago

Not sure if you still care but I finally fixed the issues (at least according the CI tests here). If you still have any issues then please don't hesitate to point them out!

eyjafjallajo commented 12 months ago

Thank you again! I mentioned one thing. At least for me popcount (2323) instruction in msvc compiler called popcnt().

kernelwernel commented 12 months ago

Thank you again! I mentioned one thing. At least for me popcount (2323) instruction in msvc compiler called popcnt().

Strange, I'll remove the builtin popcount shortcut with a manual algorithm for MSVC if that's the case.

commit link