search

kernelwernel / VMAware

VM detection library and tool
GNU General Public License v3.0
331 stars 30 forks source link

MSVC: add support for Unicode build type #40

Closed greenozon closed 6 months ago

greenozon commented 6 months ago

When setting the Unicode chars in project settings: image

the tool has some issues, eg:

image

Here is a try to address above questions: https://github.com/kernelwernel/VMAware/pull/41

kernelwernel commented 6 months ago

fixed and merged as always :)

Thanks for your effort!

greenozon commented 6 months ago

Well, no problems, that a pleasure to contribute, but you know what? when one enables Unicode chars, the current debug() tracer works with ANSI chars only (the lib is using cout, not wcout object and also there are hundreds of already existing debug() statements that are using ansi strings.. so I've commented 3 debug statements and marked with //TODO Ansi or so if you have some ideas/clues how to take care of it - lets think together!

kernelwernel commented 6 months ago

Well, no problems, that a pleasure to contribute, but you know what? when one enables Unicode chars, the current debug() tracer works with ANSI chars only (the lib is using cout, not wcout object and also there are hundreds of already existing debug() statements that are using ansi strings.. so I've commented 3 debug statements and marked with //TODO Ansi or so if you have some ideas/clues how to take care of it - lets think together!

I'll leave them like that for now, i'm really busy with things irl at the moment and the project is not really my priority for now :/

I'll try to think of a solution in the future though!