search

kernelwernel / VMAware

VM detection library and tool
GNU General Public License v3.0
291 stars 28 forks source link

3 tests are broken on windows bare metal #59

Closed fameowner99 closed 4 months ago

fameowner99 commented 4 months ago

image (1) image

kernelwernel commented 4 months ago

I've disabled the hypervisor bit and hypervisor brand techniques for Windows (by default unless specified with the VM::WIN_HYPERV_DEFAULT flag, but I'm not sure about the RDTSC technique. I could either:

  1. lower the certainty score
  2. increase the RDTSC timestamp threshold bar (from 1500ns to 2000ns)
  3. or completely disable it

I'd like to hear your thoughts.

fameowner99 commented 4 months ago

I think RDTSC threshold is Ok right now. I guess test failed because I run debug. On release all test passed.

kernelwernel commented 4 months ago

I think RDTSC threshold is Ok right now. I guess test failed because I run debug. On release all test passed.

I see, no worries!