search

kernelwernel / VMAware

VM detection library and tool
MIT License
351 stars 38 forks source link

Fixed some MSVC errors #7

Closed NotRequiem closed 11 months ago

NotRequiem commented 11 months ago

The code was modified to handle wide character strings instead of narrow character strings using MultiByteToWideChar. The original code used narrow character strings (LPCSTR or const char*) that were causing compilation issues on MSVC VS 2022

The code was also compiled and tested after the changes to ensure the modifications are ok

  1. Compilation errors in the original code: 1 2

  2. Compilation status in the modified code: 3 4 5

kernelwernel commented 11 months ago

I appreciate it, but can you tell me what compiler flags you're using? The compiler flags for cl with the cmake build is /W4 /std:c++20 /EHsc, but yours seems to be different.

NotRequiem commented 11 months ago

I appreciate it, but can you tell me what compiler flags you're using? The compiler flags for cl with the cmake build is /W4 /std:c++20 /EHsc, but yours seems to be different.

im just using /std:c++20 with MSVC, without any other flag

kernelwernel commented 11 months ago

I just want your input before I merge this, if you have any extra suggestions/changes to request then don't hesitate. If it looks good to you then let me know.

kernelwernel commented 11 months ago

I really appreciate the PR btw, thanks for being the first contributor to this project :)