Closed Formula350 closed 6 years ago
kernitus
commented
7 years ago Please enable debug mode in the config.yml and read what messages each player receives when hit by a bobber, and when the fishing rod is reeled in. This should shed more light on what exactly is going on and the exact amount of damage applied.
Formula350
commented
7 years ago Tried hitting a player once with RodFix enabled. Nothing, so I disabled and restarted server, thus, all of this is with OCM being the only plugin meant to restore combat to 1.8 ways... Config is at end of post (since I don't know of any kind of Spoiler markdown...)
When in a MultiVerse world (Flatlands) using an RPGItems "Whip" (Fishing Rod) that is set with 20 Damage (pretty sure that's 20 HP of damage) which works just fine in 1.8, attacking a player with no armor on... [1]When I hit them with the bobber: ....No damage done ....Zero Debug messages displayed [2]When I reel in the bobber: ....No damage done ....Zero Debug messages displayed [3]When I "punch" them holding the rod: ....10 Hearts of damage ....Zero Debug messages displayed
Same conditions as above except using a completely vanilla Fishing Rod using /minecraft:give Formula350 Fishing_Rod 1:
[1] Same
[2] Same
[3] 1/2 heart after 2 hits; Zero Debug Messages
Zero Errors were displayed in Console during any of this.
############# OldCombatMechanics Plugin by gvlfm78 and Rayzr522 #############
# #
# Bukkit Page: http://dev.bukkit.org/bukkit-plugins/oldcombatmechanics/ #
# Spigot Page: https://www.spigotmc.org/resources/oldcombatmechanics.19510/ #
# GitHub Page: https://github.com/gvlfm78/BukkitOldCombatMechanics/ #
# #
#############################################################################
# This is to toggle the update checker
update-checker:
enabled: true
# Modes: auto, bukkit, spigot
mode: auto
# Enable the oldcombatmechanics.toggle permission
# for players to individually /ocm toggle their cooldown
enableIndividualToggle: false
# List of interactive blocks that right clicking on will be ignored
# This is for modules such as sword blocking and elytra
# ###### I don't know if this is something we are interest in, so I've disabled it - FORM ###### #
#interactive: [enchantment_table,anvil,brewing_stand,trapped_chest,chest,bed,boat,fence_gate,dispenser,dropper,furnace,jukebox,ender_chest,stone_button,wood_button,beacon,tripwire_hook,hopper,daylight_detector,daylight_detector_inverted,item_frame,diode,diode_block_off,diode_block_on,redstone_comparator,redstone_comparator_off,redstone_comparator_on,acacia_door,birch_door,dark_oak_door,jungle_door,spruce_door,wood_door,workbench,bed_block,lever,trap_door,burning_furnace,spruce_fence_gate,birch_fence_gate,jungle_fence_gate,dark_oak_fence_gate,acacia_fence_gate,white_shulker_box,orange_shulker_box,magenta_shulker_box,light_blue_shulker_box,yellow_shulker_box,lime_shulker_box,pink_shulker_box,gray_shulker_box,silver_shulker_box,cyan_shulker_box,purple_shulker_box,blue_shulker_box,brown_shulker_box,green_shulker_box,red_shulker_box,black_shulker_box]
interactive: []
# To use the per-world feature you specify a list of the worlds in the []
# For example: (names are case sensitive)
# worlds: [world,survival,creative,SkyWars]
# Another example (for 1 world):
# worlds: [bestWorld]
disable-attack-cooldown:
# This is to disable the attack cooldown
enabled: true
worlds: []
# What to set the attack speed to. Default for 1.9 is 4, at least 16 is needed for no cooldown.
generic-attack-speed: 24
disable-player-collisions:
# This is to disable player collision
# This is now compatible with scoreboard and tablist-editing plugins
enabled: true
worlds: []
disable-sword-sweep:
# This is to disable the sword sweep attack
# The particle effect will still be present but will not affect surrounding entities
enabled: true
worlds: []
disable-crafting:
# Disable the crafting of specified items
enabled: false
worlds: []
# List of denied items
denied: [shield]
disable-offhand:
# Disable the usage of the offhand
# Won't affect sword-blocking module
enabled: false
worlds: []
# Whether the following list blocks items or allows them
whitelist: false
# List of items that should be allowed/not
# Example: [diamond_sword,BOW]
items: []
old-brewing-stand:
# Automatically refuels brewing stands
enabled: false
worlds: []
no-lapis-enchantments:
# Automatically adds lapis to enchantment tables upon opening
enabled: false
worlds: []
# Whether to only allow this for players with oldcombatmechanics.nolapis permission
usePermission: false
disable-elytra:
# Do not allow players to wear elytra
enabled: false
worlds: []
disable-enderpearl-cooldown:
# Disables enderpearl cooldown
enabled: true
worlds: []
old-tool-damage:
# This is to set the tool damage as in pre-1.9
# NOTE: this will modify the damage, however on the item tooltip it will still show the 1.9+ damage
enabled: true
worlds: []
# This will allow you to set the damage divider
# The default values below are obtained by doing (1.8 value)/(1.9 value)
# Only axes and shovel values changed between the versions, so all others here have a divider of 1
# We put them here anyway in case you wished to change them.
# The plugin subtracts the enchantment-added damage,
# divides the damage done while holding the weapon by the following values,
# and adds back on the enchantment-added damage.
damages:
# Axe damages
GOLD_AXE: 2.333333
WOOD_AXE: 2.333333
STONE_AXE: 2.25
IRON_AXE: 1.8
DIAMOND_AXE: 1.5
# Shovel damages
GOLD_SPADE: 2.5
WOOD_SPADE: 2.5
STONE_SPADE: 1.75
IRON_SPADE: 1.5
DIAMOND_SPADE: 1.375
# Sword damages
GOLD_SWORD: 1
WOOD_SWORD: 1
STONE_SWORD: 1
IRON_SWORD: 1
DIAMOND_SWORD: 1
# Pickaxe damages
GOLD_PICKAXE: 1
WOOD_PICKAXE: 1
STONE_PICKAXE: 1
IRON_PICKAXE: 1
DIAMOND_PICKAXE: 1
# Hoe damages
GOLD_HOE: 1
WOOD_HOE: 1
STONE_HOE: 1
IRON_HOE: 1
DIAMOND_HOE: 1
sword-blocking:
# This is to allow players to block with swords again by getting a shield while they hold right click with a sword
enabled: false
worlds: []
# How much damage should blocking reduce
# This can either be a number in half-hearts (e.g 2) or a percentage (e.g. 20%)
# 1.8 default: 50% 1.9 default: 33%
blockingDamageReduction: 50%
# Whether shields can block damage entirely
# In 1.8 blocking could only reduce to 1/2 a heart
shieldFullBlock: false
# The minimum amount of damage, in half-hearts, if shieldFullBlock is enabled
minimumDamage: 1.0
# How often, it ticks, should OCM check if the player is still blocking with the shield and remove it if not
# If this is too fast the player will have their shield disappear before they're able to block again causing a slight delay
# If this is too slow players will have a shield in their hand well after they've stopped blocking
# 20 ticks = 1 second
restoreDelay: 40
# List of items that holding in the offhand while right-clicking with a sword doesn't trigger blocking e.g. bow
noBlockingItems: []
# Whether the above list should act as a blacklist (i.e. only items in it stop the blocking mechanic)
blacklist: true
old-golden-apples:
# This is to change the behaviour / crafting of golden apples to how it was in pre-1.9
# WARNING: If on 1.12 or above and you disable this module you must reload the server for the recipe to disappear
enabled: true
worlds: []
# If you want to allow enchanted golden apple crafting
enchanted-golden-apple-crafting: true
# Enabling this makes the potion effects gained by eating golden apples
# and enchanted golden apples the same as it was in pre-1.9
old-potion-effects: true
# Potion effects golden apples should apply
# Duration is in ticks (20 ticks = 1 second)
# Amplifier is potion level -1, so Regeneration IV would be amplifier 3
gapple-effects:
regeneration:
duration: 100
amplifier: 1
absorption:
duration: 2400
amplifier: 0
# Potion effects enchanted golden apples should apply
napple-effects:
regeneration:
duration: 600
amplifier: 4
damage_resistance:
duration: 6000
amplifier: 0
fire_resistance:
duration: 6000
amplifier: 0
absorption:
duration: 2400
amplifier: 0
# Enable this if you have another plugin which adds a crafting recipe for
# enchanted golden apples (requires server restart)
no-conflict-mode: false
old-fishing-knockback:
# This is to make the knockback of players when they get hit by a fishing bobber the same as it was in pre-1.9
# Credit to HyKurtis for the original code, optimised by Rayzr522
enabled: false
worlds: []
# This makes OCM check if other plugins are stopping the rod damage and follow their choice
# Set to false to always have rod damage
checkCancelled: false
# This is the damage done by the fishing rod attack
damage: 0.2
# Whether the EntityDamageEvent should be used instead of the EntityDamageByEntityEvent
# Set to true when using plugins like NCP that check range
useEntityDamageEvent: false
projectile-knockback:
# This adds knockback and/or damage to players when they get hit by snowballs, eggs & enderpearls
# This has been a Bukkit bug for so long people thought it was vanilla when it was recently patched
enabled: true
worlds: []
# This is the damage done by each projectile
damage:
snowball: 0.1
egg: 0.1
ender_pearl: 0.1
old-player-regen:
# This is to make players' regeneration act mostly like it did in pre-1.9
# It's hard to make it behave exactly like before, but in general this makes it work like in pre-1.9
enabled: true
worlds: []
# How often, in seconds, a player should regenerate health
frequency: 3
# How many half-hearts the player should heal by, every seconds specified above
amount: 1
# How much exhaustion healing should give to the player. In 1.8: 3 In 1.9: 4 in 1.11: 6
# If, after adding this, Minecraft finds the value is above 4, it subtracts 4
# and either reduces saturation or, if saturation is 0, reduces food level by 1 (1/2 a stick)
exhaustion: 3
old-armour-strength:
# This is to set armour strength values as in pre-1.9
enabled: true
worlds: []
# The higher the armour toughness value the closer the damage done while wearing armour is to pre-1.9 values
toughness: 9999
# This is to change the armour strength values if you so wish
strength:
# Leather armour
LEATHER_HELMET: 1
LEATHER_CHESTPLATE: 3
LEATHER_LEGGINGS: 2
LEATHER_BOOTS: 1
# Chainmail armour
CHAINMAIL_HELMET: 2
CHAINMAIL_CHESTPLATE: 5
CHAINMAIL_LEGGINGS: 4
CHAINMAIL_BOOTS: 1
# Golden armour
GOLD_HELMET: 2
GOLD_CHESTPLATE: 5
GOLD_LEGGINGS: 3
GOLD_BOOTS: 1
# Iron armour
IRON_HELMET: 2
IRON_CHESTPLATE: 6
IRON_LEGGINGS: 5
IRON_BOOTS: 2
# Diamond armour
DIAMOND_HELMET: 3
DIAMOND_CHESTPLATE: 8
DIAMOND_LEGGINGS: 6
DIAMOND_BOOTS: 3
disable-projectile-randomness:
# This is to remove projectile randomness while firing arrows with a bow
# This is actually a very old feature and has been in the game for quite some time
enabled: false
worlds: []
disable-bow-boost:
# This is to stop players from boosting themselves forward by hitting themselves
# while running with a punch II arrow from their bow
# This module just stops them from hitting themselves with arrows entirely
enabled: false
worlds: []
################################
#### SPECIAL SETTINGS BELOW ####
################################
# This enables debug messages, only enable when troubleshooting
debug:
enabled: true
# DO NOT CHANGE THIS NUMBER AS IT WILL RESET YOUR CONFIG
config-version: 23
# Not added yet
old-potion-effects:
# This is to restore the 1.8 potion effects before they were nerfed
enabled: true
# Poison potion II
8228:
poison:
duration: 440
amplifier: 1????
# Extended Poison potion
8260:
poison:
duration: 2400
amplifier: 0????
# Extended Regeneration potion
8257:
regeneration:
duration: 2400
amplifier: 0????Update: Killed a Creeper with that same Fishing Rod (via bobber) and it also received no Debug text; on cast or reel in.
All in all, seems like something is completely hijacking the Fishing Rod mechanics away from OCM, and with RodFix disabled, I'm not sure what it could be other than maybe mcMMO?
kernitus
commented
7 years ago Try hitting another players, and seeing if that players receives a debug message when hit by the rod.
Formula350
commented
7 years ago Yea, there were 4 of us playin around at one point :\ No Debug Messages were displaying for any of us, and this was all occurring in the same MultiVerse world that I was in for the Sweeping Edge tests.
I had forgotten to try it in vanilla World, so I'll go give that a shot quick,
kernitus
commented
7 years ago I've just tested this again on my test server in the latest OCM build, everything works fine, exactly as it has been for quite some time. This should mean it is another plugin that is interfering with OCM's fishing rods.
Formula350
commented
7 years ago Are you only using OCM, a permissions management plugin, maybe Essentials (or similar) when testing? Or do you have a huge arrangement of them installed, to create similar conditions to that of most deployed servers?
I can try to have just some vanilla items at the ready and only OCM loaded. Problem is that I'm not sure how to make a Whip-like item with Vanilla commands, where whatever damage/enchant will transfer to the bobber entity. (Unless things have changed and a fishing rod with NBT modified damage will deal that damage amount to the bobber? Which I can certainly test.)
Will let you know.
OCM v1.6.2 build 60 (tried build 8, v1.6.1, v1.4.2, v,1.1.2) Spigot 1.11.2 as far as I know (git-Spigot-3fb9445-6e3cec8) RPGItems for 1.11.2 v3.5.255
We use RPGItems and have been for a number of years, so we've accumulated quite the armory. Some of those include "Whips" which are Fishing Rods.
[Not 100% sure if this was the case in 1.9+OCM]The bobber did not damage on contact, only on the Reel-in action (second click). In addition to that, the damage seemed to now be slightly inaccurate based on the damage reported by MobHealth (damage indicator plugin, which reported damage correctly in 1.8); where it would even 1-hit mobs that it should not have been capable of. The set damage was "30" (which in RPGItems terms I believe is in HitPoints) but was reporting as doing ~1240! Worse yet, is that it wouldn't always do damage, it was a huge lottery where it might damage the first hit, second, third, then no damage... Sometimes it would fail to do any damage a number of times in a row, and just reel the mob in a block. There are also a few MythicMobs that simply refuse to take damage from these Whips now, no matter how many times you try. Whether or not it matters, these specific ones are Wither Skeletons with roughly 1000hp and they're in a non-Nether world, but that hadn't caused any problems in 1.8 so I don't know...Nevertheless, I've tried everything I could in the config, from adjusting the Fishing Rod damage up to 2.0, disabling the Knockback, toggling "checkCanceled", changing the damage method to useEntityDamageEvent, and various combinations. :\ Currently the most effective setup seems to be, which might be placebo, using OCM with default Fishing Rod mechanics, along with the RodFix plugin.
Is everything working as intended or is something not quite right? Also, does Spigot allow for triggering an event when the bobber lands instead of when it's reeled in, and if so would it be possible to offer a config option to define which even the damage is inflicted?
Thanks -Formula350