kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics for 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
173 stars 73 forks source link

Knockback on armour stands #520

Closed refractored closed 3 years ago

refractored commented 3 years ago

Information

Problem Description

### To Reproduce Steps to reproduce the behavior: 1. W tap an armor stand ### Expected Behaviour The armor stand to stay in place when W tapped ### Actual Behaviour

The armor stand gets knocked back with the W tap. The armor stand does not get knocked back for other regular knockback

https://www.youtube.com/watch?v=ZvWUoGCHcNY

kernitus commented 3 years ago

What does "W tap" mean? Are you just hitting an armour stand?

kernitus commented 3 years ago

Also I suspect this has to do with the old knockback module, perhaps there should be a black/white list of entities on which to apply knockback.

refractored commented 3 years ago

What does "W tap" mean? Are you just hitting an armour stand?

Basically, W tapping is you stop pressing w after you hit your opponent and start pressing w again when you're about to hit your opponent again. The point of this is to deal extra knockback then just holding w and hitting your opponent.

detobel36 commented 3 years ago

I think it is not limited to armor stand...

https://www.youtube.com/watch?v=klNiH3YNUTw

kernitus commented 3 years ago

Hold on, the old player knockback module only modifiers knockback if the entity being hit is a player. It does not touch anything else at all. Does this problem still happen if that module is disabled?

refractored commented 3 years ago

I think it is not limited to armor stand...

https://www.youtube.com/watch?v=klNiH3YNUTw

Yeah, it isn't limited to armor stands. I'm saying that W-Tapping/Sprint-Resetting shouldn't be knocking back armor stands as well. The module works fine otherwise.

refractored commented 3 years ago

Seems like I'm an idiot and armor stands get knocked back without OCM. Sorry for the trouble.