kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics for 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
173 stars 73 forks source link

shield-damage-reduction not working as intended #529

Closed M4RC0Sx closed 3 years ago

M4RC0Sx commented 3 years ago

Information

Problem Description

shield-damage-reduction option is not working as intended. When disabling it, you become completely invulnerable. But when you enable it, the percentage is not working. For example, having this enabled, if I get hit with a sword and I don't block it, I get 2 hearts damage but if I block it with the shield, I get 3 hearts damage.

### To Reproduce Steps to reproduce the behavior: 1. Enable shield-damage-reduction 2. Hit with a sword and don't block the hit 3. Hit with a sword and block the hit 4. See how the damage is not consistent, you should recieve more damage if you are not blocking. ### Expected Behaviour You should recieve more damage if you are not blocking. ### Actual Behaviour

You get more damage blocking with a shield.

kernitus commented 3 years ago

Should be fixed in dcd9ed1

M4RC0Sx commented 3 years ago

@kernitus It is working with players but not with mobs.

kernitus commented 3 years ago

@M4RC0Sx mobs as in mobs attacking you while holding your shield up? Do you have any debug log data of that example?