search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
168 stars 71 forks source link

Fix knockback #552

Closed Gerrygames closed 2 years ago

Gerrygames commented 3 years ago

Sometimes? the PlayerVelocityEvent is not called after the EntityDamageByEntityEvent. This leads to the knockback that remains in the playerKnockbackHashMap to be applied later when it should't. https://www.youtube.com/watch?v=t43PhgVQSpM

kernitus commented 3 years ago

Can you please explain why you've changed the code this way? Are you clearing the knockback hashmap every single tick??

NikV2 commented 2 years ago

Vouch for this change, OCM's velocity module has issues with many external plugins.

kernitus commented 2 years ago

Fixed with caf99eb59e894ba6a143cbcbcf671203128476cb