search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
168 stars 71 forks source link

Damage speed issue on 1.17.1 #558

Closed ElFlyGod closed 3 years ago

ElFlyGod commented 3 years ago

Problem Description

Hits are registering super fast if you click fast, compared to a vanilla fast attack speed sword, ocm version is extremely fast,

Below are gifs showcasing how it should be vs how it is on oldcombatmechanics This behavior also applies to mobs not just players.

Steps to reproduce the behavior:

  1. Spawn a vanilla wood sword with fast attack speed /give ElFly wooden_sword{AttributeModifiers:[{AttributeName:"generic.attack_speed",Amount:500,Name:"generic.attack_speed",UUID:[I;-121723,22324,20043,-44648]},{AttributeName:"generic.attack_damage",Amount:4,Name:"generic.attack_damage",UUID:[I;-121723,22424,20043,-44848]}]} 1

  2. Compare speed with ocm enabled, using a regular sword

  3. Unload ocm, try with command spawned sword, will notice that the spawned one is doing the proper speed while OCM previously was much faster

Expected Behaviour

Not sure what to call it but you should be able to attack much slower This is how it should look: https://i.gyazo.com/050fe2625647a4242cb3f33aef45ccb2.mp4

Actual Behaviour

Clicking fast makes health go down A LOT faster. This is how it looks now (super fast): https://i.gyazo.com/fff837925d137f8b2f5b13d50cba035b.mp4

kernitus commented 3 years ago

I believe this is a duplicate of #554