search

kernitus / BukkitOldCombatMechanics

Spigot plugin to configure combat mechanics from 1.9 onwards
https://www.spigotmc.org/resources/19510/
Mozilla Public License 2.0
168 stars 71 forks source link

Fix double velocity on fall damage #576

Closed KamelaJda closed 2 years ago

KamelaJda commented 2 years ago

Fix #569

MWHunter commented 2 years ago

This won't fix the issue, there's something in bukkit where the event isn't getting called, for some reason. Maybe it's damage immunity, maybe it's something else. Anyways, the fix should be to clear the hashmap every tick. This will prevent the player from holding onto a pending knockback. I use this fix in LegacyKB and people haven't complained yet. I don't know why bukkit is inconsistent here.

The reason why this specific fix won't do anything is that unless the damage cause is from a player attack, then they won't get in the hashmap in the first place. Clearing the hashmap on a bukkit schedule will fix this issue.